From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH 3/7] eal: move virtual device probing into a
	bus
Date: Wed, 15 Feb 2017 19:45:39 +0530
Message-ID: <485202cf-3644-5ee9-45b5-d443569bf5b5@nxp.com>
References: <1487152929-23627-1-git-send-email-jblunck@infradead.org>
 <1487152929-23627-4-git-send-email-jblunck@infradead.org>
 <bfb6d89d-5043-c92d-8894-5d92b6e7d74d@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
To: Jan Blunck <jblunck@infradead.org>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0057.outbound.protection.outlook.com [104.47.33.57])
 by dpdk.org (Postfix) with ESMTP id BBDD6201
 for <dev@dpdk.org>; Wed, 15 Feb 2017 15:10:51 +0100 (CET)
In-Reply-To: <bfb6d89d-5043-c92d-8894-5d92b6e7d74d@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wednesday 15 February 2017 07:41 PM, Shreyansh Jain wrote:
> On Wednesday 15 February 2017 03:32 PM, Jan Blunck wrote:
>> This is a refactoring of the virtual device probing which moves into into
>> a proper bus structure.
>>
>> Signed-off-by: Jan Blunck <jblunck@infradead.org>
>> ---
>>  lib/librte_eal/common/eal_common_dev.c  | 22 -----------------
>>  lib/librte_eal/common/eal_common_vdev.c | 44
>> +++++++++++++++++++++++++++++++++
>>  2 files changed, 44 insertions(+), 22 deletions(-)
>>
>
> [...]
>
>>
>> diff --git a/lib/librte_eal/common/eal_common_vdev.c
>> b/lib/librte_eal/common/eal_common_vdev.c
>> index 7d6e54f..523a3d6 100644
>> --- a/lib/librte_eal/common/eal_common_vdev.c
>> +++ b/lib/librte_eal/common/eal_common_vdev.c
>> @@ -37,8 +37,10 @@
>>  #include <stdint.h>
>>  #include <sys/queue.h>
>>
> [...]
>
>> +
>> +static struct rte_bus rte_vdev_bus = {
>> +    .scan = vdev_scan,
>> +    .probe = vdev_probe,
>> +};
>> +
>> +RTE_REGISTER_BUS_LATE(virtual, rte_vdev_bus);
>>
>
> Does it matter if VDEV buses are registered before or after other
> buses? Either way, the callbacks would be called in the order specified
> in EAL.
>
>

Just ignore this comment - I am misunderstood something.

But another question: Is there specific reason VDEV should be 
registered/scanned *after* other devices? Is there some specific problem 
if we do otherwise? (I think this is should be done, but I don't have a 
specific reason).