From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] app/testpmd: app/testpmd: add device removal command Date: Mon, 28 Aug 2017 13:00:24 +0200 Message-ID: <48531686.15frCTT1P0@xps> References: <1503499024-12480-1-git-send-email-rasland@mellanox.com> <20170828095523.GE8124@bidouze.vm.6wind.com> <2200a72f-92bb-c4e6-db9d-b00961fc328b@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Raslan Darawsheh , jingjing.wu@intel.com, salehals@mellanox.com To: Ferruh Yigit Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6088A137C for ; Mon, 28 Aug 2017 13:00:27 +0200 (CEST) In-Reply-To: <2200a72f-92bb-c4e6-db9d-b00961fc328b@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/08/2017 12:30, Ferruh Yigit: > On 8/28/2017 10:55 AM, Ga=EBtan Rivet wrote: > > Hi Raslan, > >=20 > > Redoing the review with the remarks from Thomas in mind. > >=20 > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > >> Added hotplug in testpmd, to be able to test hotplug function > >> in the PMD's. > >> > >> Signed-off-by: Raslan Darawsheh > >> --- > >> app/test-pmd/cmdline.c | 44 +++++++++++++++++++++++++++++++++++++++++= +++ > >> app/test-pmd/testpmd.c | 18 ++++++++++++++++++ > >> app/test-pmd/testpmd.h | 1 + > >> 3 files changed, 63 insertions(+) > >> > >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > >> index cd8c358..b32a368 100644 > >> --- a/app/test-pmd/cmdline.c > >> +++ b/app/test-pmd/cmdline.c > >> @@ -716,6 +716,9 @@ static void cmd_help_long_parsed(void *parsed_resu= lt, > >> "port config (port_id|all) l2-tunnel E-tag" > >> " (enable|disable)\n" > >> " Enable/disable the E-tag support.\n\n" > >> + > >> + " device remove (device)\n" > >=20 > > I think (device) might be hard to understand for a user. > > Maybe (device name)? >=20 > I am suspicious on adding new root level command to testpmd, it is > getting bigger, each command looks OK on its own context, but as a whole > app getting more confusing [1]. We can keep the root level "port" if we make clear that the impact is beyond the port. > Since dealing with device is kind of new, it can be OK to create new > command tree, but there are already hotplug commands per port: > "port attach #PCI|#VDEV_NAME" > "port detach #P" >=20 > perhaps it can be good to keep "attach", "detach" keywords for device to > be consistent? Not sure. Anyway ethdev attach and detach should be deprecated. We are moving to a more correct design where hotplug is done at EAL level. > "device attach #name" > "device detach #name" >=20 > Also a show equivalent can be added to work in device level: > "show device info" >=20 >=20 > [1] > http://dpdk.org/ml/archives/dev/2017-August/072764.html