From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] service: fix service lcore stop function
Date: Fri, 15 Sep 2017 15:34:30 +0200
Message-ID: <48564633.AYoj5gbtiS@xps>
References: <20170906071541.1922-1-gprathyusha@caviumnetworks.com>
 <E923DB57A917B54B9182A2E928D00FA640C753A9@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 2DAC91396
 for <dev@dpdk.org>; Fri, 15 Sep 2017 15:34:32 +0200 (CEST)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA640C753A9@IRSMSX102.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > lcore_states store the state of the lcore. Fixing the invalid
> > dereference of lcore_states with service number
> > 
> > Unit test case service_lcore_start_stop fails with the above fix.
> > Service core was stopped without stopping the service.
> > 
> > This commit fixes the test by adding negative and positive cases of
> > stopping the service lcore before and after stopping the service
> > respectively
> > 
> > Fixes: 21698354c832 ("service: introduce service cores concept")
> > Fixes: f038a81e1c56 ("service: add unit tests")
> > 
> > Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
> 
> Thanks for fixing and rebase / update to v2. Please mark the v1 of this patchset as "Superseded" in patchwork.
> 
> Reviewed-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks