From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] examples/flow_filtering: demo of simple
	rte flow
Date: Fri, 27 Oct 2017 01:14:15 +0200
Message-ID: <4865583.3QcsuuSVpe@xps>
References: <1508407471-6252-1-git-send-email-orika@mellanox.com>
 <28eeef90ebaf5e8afb31837fade1b36c484f29a5.1508953769.git.orika@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, john.mcnamara@intel.com
To: Ori Kam <orika@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 37C4C1BB26
 for <dev@dpdk.org>; Fri, 27 Oct 2017 01:14:17 +0200 (CEST)
In-Reply-To: <28eeef90ebaf5e8afb31837fade1b36c484f29a5.1508953769.git.orika@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Few comments below, Ori:

25/10/2017 19:58, Ori Kam:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -978,3 +978,7 @@ F: examples/tep_termination/
>  F: examples/vmdq/
>  F: examples/vmdq_dcb/
>  F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst
> +
> +M: Ori Kam <orika@mellanox.com>
> +F: examples/flow_filtering/
> +F: doc/guides/sample_app_ug/flow_filtering.rst

Please keep examples in alphabetical order.

> --- a/doc/guides/sample_app_ug/index.rst
> +++ b/doc/guides/sample_app_ug/index.rst
> @@ -77,6 +77,7 @@ Sample Applications User Guides
>      ptpclient
>      performance_thread
>      ipsec_secgw
> +    flow_filtering

I don't know whether there is an order in this index.

> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -100,5 +100,6 @@ endif
>  endif
>  
>  DIRS-y += eventdev_pipeline_sw_pmd
> +DIRS-y += flow_filtering

Most of apps are in alphabetical order in this Makefile.

> --- /dev/null
> +++ b/examples/flow_filtering/Makefile
> @@ -0,0 +1,17 @@

A license header is required.

> +ifeq ($(RTE_SDK),)
> +$(error "Please define RTE_SDK environment variable")
> +endif
> +
> +# Default target, can be overridden by command line or environment
> +RTE_TARGET ?= x86_64-native-linuxapp-gcc
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +APP = flow
> +
> +SRCS-y := main.c
> +
> +CFLAGS += -g3

-g3 ? Is it a mistake?

> --- /dev/null
> +++ b/examples/flow_filtering/main.c
> @@ -0,0 +1,244 @@
> +/*-
> + *   BSD LICENSE
> + *
> + *   Copyright 2017 Mellanox.
> + *
> + *   Redistribution and use in source and binary forms, with or without
> + *   modification, are permitted provided that the following conditions
> + *   are met:
> + *
> + *     * Redistributions of source code must retain the above copyright
> + *       notice, this list of conditions and the following disclaimer.
> + *     * Redistributions in binary form must reproduce the above copyright
> + *       notice, this list of conditions and the following disclaimer in
> + *       the documentation and/or other materials provided with the
> + *       distribution.
> + *     * Neither the name of 6WIND S.A. nor the names of its

Wrong copyright holder reference here.