From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] app/testpmd: fix testpmd exit for ctrl+d
Date: Thu, 26 Jul 2018 16:14:33 +0200
Message-ID: <4866271.duVD2LWeSr@xps>
References: <20180723104425.10090-1-jasvinder.singh@intel.com>
 <1532441847-7492-1-git-send-email-reshma.pattan@intel.com>
 <3AEA2BF9852C6F48A459DA490692831F2A37617A@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Singh,
 Jasvinder" <jasvinder.singh@intel.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
 Mordechay Haimovsky <motih@mellanox.com>, cristian.dumitrescu@intel.com
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8701C25D9
 for <dev@dpdk.org>; Thu, 26 Jul 2018 16:14:39 +0200 (CEST)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A37617A@IRSMSX109.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

24/07/2018 16:46, Pattan, Reshma:
> + CC: Olivier and Mordechay Haimovsky. 
> 
> > Testpmd should be existed gracefully when ctrl+d is typed.
> > This behaviour is not handled properly, fix this by calling
> > pmd_test_exit() instead of rte_panic.
> > 
> > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
> > 
> > Reported-by: Mordechay Haimovsky <motih@mellanox.com>
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> > ---
> > v2: removed changes done to lib/librte_cmdline/cmdline.c reworded commit
> > message and heading.

The partial revert from Moti is preferred.