From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH v5 3/5] bus: introduce new log type for bus
	drivers
Date: Wed, 11 Oct 2017 18:42:37 +0800
Message-ID: <4883d822-9aa0-4b88-048c-35d7e9da9c1c@intel.com>
References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com>
 <1507548444-33959-1-git-send-email-jianfeng.tan@intel.com>
 <1507548444-33959-4-git-send-email-jianfeng.tan@intel.com>
 <7732f195-64fd-308c-8faf-c1b0e37d3453@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, jblunck@infradead.org, bruce.richardson@intel.com,
 konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com,
 thomas@monjalon.net, yliu@fridaylinux.org, maxime.coquelin@redhat.com,
 mtetsuyah@gmail.com, ferruh.yigit@intel.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 7BDDB1B1EB
 for <dev@dpdk.org>; Wed, 11 Oct 2017 12:42:41 +0200 (CEST)
In-Reply-To: <7732f195-64fd-308c-8faf-c1b0e37d3453@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 10/11/2017 2:54 PM, Shreyansh Jain wrote:
> Hello Jianfeng,
>
> On Monday 09 October 2017 04:57 PM, Jianfeng Tan wrote:
>>
[...]
>> -#define PMD_DRV_LOG(level, fmt, args...) \
>> -    PMD_DRV_LOG_RAW(level, fmt "\n", ## args)
>> +#define FSLMC_VFIO_LOG(level, fmt, args...) \
>> +    RTE_LOG(level, EAL, "%s(): " fmt "\n", __func__, ##args)
>
> This change breaks the FSLMC bus driver. There are macros like 
> PMD_DRV_LOG which are still in use in the code.
> Before removing the above, those would have to be restructured.

Just try to change all PMD_DRV_LOG in fslmc to FSLMC_VFIO_LOG. As you 
are working on that, I will drop it.

>
> I am already working on converting this logging into dynamic logging.
> Can you skip this work until then? Does it block your work?

Do you mean you are working on introducing a new log type for bus drivers?

Thanks,
Jianfeng