From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: Issue on rte_sched.c
Date: Sun, 01 May 2016 21:58:06 +0200
Message-ID: <4885249.p6c3dYjJKD@xps13>
References: <CADoa0bbHpkyzJ7-VJAxHPXgOj7uJiLbo_V3iSKgJzNEy4G83aw@mail.gmail.com>
 <132784424.Pjq79LXnpm@xps13>
 <CADoa0bZQw565CdMwhnfBF4=vhkO0AgaUe4+d+QCBZBe0QUSJmg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ariel Rodriguez <arodriguez@callistech.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id A9E162BA8
 for <dev@dpdk.org>; Sun,  1 May 2016 21:58:08 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id g17so19162511wme.0
 for <dev@dpdk.org>; Sun, 01 May 2016 12:58:08 -0700 (PDT)
In-Reply-To: <CADoa0bZQw565CdMwhnfBF4=vhkO0AgaUe4+d+QCBZBe0QUSJmg@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-04-30 05:50, Ariel Rodriguez:
> Yes i am refereing on that commit.
> 
> About RTE_MACHINE_CPUFLAG_* , i agreed.
> 
> I never prepare a patch ... maybe is time to put my hands on that.

Yes it is a good way to make your first patch.
See http://dpdk.org/dev#send
Thanks

> 2016-04-13 20:35, Ariel Rodriguez:
> > Hello, viewing the new code of librte_sched/ i found this line strange ...
> >
> > #if defined(__SSE4__)
> 
> Are you refering to http://dpdk.org/commit/90f455f ?
> 
> > if instead i use :
> >
> > #if defined(__SSE4_2__) || defined(__SSE4_1__)
> >
> > works like a charm ...
> >
> > i never see in any directive like __SSE4__
> 
> Indeed, it is strange.
> By the way, it is recommended to use RTE_MACHINE_CPUFLAG_*.