Re: [PATCH 1/7] bus/fslmc: fix build of qbman debug code

[hemant.agrawal@nxp.com]

On 05/09/2026 00:42, Stephen Hemminger wrote:
> QBMAN_RESPONSE_VERB_MASK is a private define in qbman_portal.c, not
> in the qbman_portal.h header included by qbman_debug.c.
> The debug file has therefore never compiled since it was added;
> it fails with seven "undeclared identifier" errors when
> RTE_LIBRTE_DPAA2_DEBUG_BUS is defined.
>
> Define the mask locally, next to the other management command codes
> that qbman_debug.c already defines for itself.
>
> Fixes: 64f131a82fbe ("bus/fslmc: add qbman debug")
> Cc: stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> ---
>   drivers/bus/fslmc/qbman/qbman_debug.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/fslmc/qbman/qbman_debug.c b/drivers/bus/fslmc/qbman/qbman_debug.c
> index f13168dce3..1c5c62addb 100644
> --- a/drivers/bus/fslmc/qbman/qbman_debug.c
> +++ b/drivers/bus/fslmc/qbman/qbman_debug.c
> @@ -9,6 +9,9 @@
>   
>   #include <eal_export.h>
>   
> +/* Mask used to extract the response verb from a management command result */
> +#define QBMAN_RESPONSE_VERB_MASK  0x7f
> +
>   /* QBMan portal management command code */
>   #define QBMAN_BP_QUERY            0x32
>   #define QBMAN_FQ_QUERY            0x44