From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: Re: [PATCH] kni: fix ethtool build with kernel 4.11
Date: Wed, 3 May 2017 19:06:46 +0200
Message-ID: <48ab36d4-db15-4a46-dc8e-03954ed55452@6wind.com>
References: <20170503160016.31375-1-ferruh.yigit@intel.com>
 <d2cc241a-52d6-a332-24d0-69eb64e0f55e@6wind.com>
 <cc0171a5-8a6e-11a6-d8e0-ae4b3fa52c4c@intel.com>
Reply-To: nicolas.dichtel@6wind.com
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 0995E330D
 for <dev@dpdk.org>; Wed,  3 May 2017 19:06:41 +0200 (CEST)
Received: by mail-wm0-f49.google.com with SMTP id u65so153741252wmu.1
 for <dev@dpdk.org>; Wed, 03 May 2017 10:06:41 -0700 (PDT)
In-Reply-To: <cc0171a5-8a6e-11a6-d8e0-ae4b3fa52c4c@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Le 03/05/2017 à 18:43, Ferruh Yigit a écrit :
> On 5/3/2017 5:39 PM, Nicolas Dichtel wrote:
>> Le 03/05/2017 à 18:00, Ferruh Yigit a écrit :
>>> build error:
>>> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10:
>>> error: implicit declaration of function ‘pci_enable_msix’
>>> [-Werror=implicit-function-declaration]
>>>     err = pci_enable_msix(pdev,
>>>               ^~~~~~~~~~~~~~~
>>>
>>> This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option
>>> enabled.
>>>
>>> Following Linux commit removes the pci_enable_msix()
>>> Linux: 4244de1c64de ("PCI: remove pci_enable_msix")
>>>
>>> Switch to pci_enable_msix_range() for kernel > 4.8 since current Linux
>>> igb driver uses this function.
>> When looking at the kernel patches, it seems that the way to go is to use
>> pci_alloc_irq_vectors(), but it needs a bit more work.
> 
> I remember this from your igb_uio fix, but latest igb kernel driver uses
> pci_enable_msix_range(), I found it easy and safe to replicate it.
Ok.

> 
> We can update it when kernel igb driver updates the code, unless you
> have a strong opinion to switch pci_alloc_irq_vectors() in advance?
No, I don't mind.

Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Regards,
Nicolas