From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] mk: generate internal library dependencies
	from DEPDIRS-y automatically
Date: Tue, 07 Jun 2016 16:19:47 +0200
Message-ID: <4901376.7OB1d4j3hA@xps13>
References: <62da0f5f31b2ab9db2dcc16acd2f8425a575a26f.1465293714.git.pmatilai@redhat.com>
 <24422417.UYSFgAybK6@xps13> <20160607140715.GC6948@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
 Panu Matilainen <pmatilai@redhat.com>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>, olivier.matz@6wind.com
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id 5940E95EF
 for <dev@dpdk.org>; Tue,  7 Jun 2016 16:19:49 +0200 (CEST)
Received: by mail-wm0-f41.google.com with SMTP id v199so21939645wmv.0
 for <dev@dpdk.org>; Tue, 07 Jun 2016 07:19:49 -0700 (PDT)
In-Reply-To: <20160607140715.GC6948@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-07 15:07, Bruce Richardson:
> On Tue, Jun 07, 2016 at 03:00:45PM +0200, Thomas Monjalon wrote:
> > 2016-06-07 14:36, Christian Ehrhardt:
> > > But I still struggle to see how to fix the circular dependency between
> > > librte_eal and librte_mempool.
> > 
> > Why is there a circular dependency?
> > Only because of logs using mempool?
> > 
> > > Maybe now is a time to look at this part of the original threads again to
> > > eventually get apps less overlinked?
> > > => http://www.dpdk.org/ml/archives/dev/2016-May/039441.html
> > > My naive suggestions in generalized form can be found there (no answer yet):
> > > =>
> > > http://stackoverflow.com/questions/37351699/how-to-create-both-so-files-for-two-circular-depending-libraries
> > 
> > I would prefer removing the circular dependency.
> > Maybe we can rewrite the code to not use mempool or move it outside of EAL.
> 
> Or else we can take the attitude that the mempools and the rings are just a core
> part of DPDK and move them and the EAL into a dpdk_core library at link time.
> Having the code separate in the git tree is good, but I'm not sure having
> the resulting object files being in separate .a/.so files is particularly useful.
> I can't see someone wanting to use one without the other.

EAL could be used as an abstraction layer on top of systems and platforms.
And I think keeping things separated and layered help to maintain a design
easy to understand.