From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] nfp: using random mac address if not a configured mac Date: Tue, 13 Sep 2016 21:30:09 +0200 Message-ID: <4929828.LndqCPGnUK@xps13> References: <1471360528-13477-1-git-send-email-alejandro.lucero@netronome.com> <9fbfe918-5a09-46c1-2c85-928fac9d7c0d@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit To: Alejandro Lucero Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 3003C6CD6 for ; Tue, 13 Sep 2016 21:30:12 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id i130so12573798wmf.0 for ; Tue, 13 Sep 2016 12:30:12 -0700 (PDT) In-Reply-To: <9fbfe918-5a09-46c1-2c85-928fac9d7c0d@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-09-13 18:10, Ferruh Yigit: > Hi Alejandro, > > On 8/16/2016 4:15 PM, Alejandro Lucero wrote: > > Signed-off-by: Alejandro Lucero > > --- > > There are following checkpatch warnings, also check-git-log complains: > > Headline too long: > nfp: unregister interrupt callback function when closing device Just a tip to keep headlines short: you can often remove some common words. Here we still understand the idea without "function" and "device". nfp: unregister interrupt callback when closing