From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] tools: add tags and cscope index file
	generation support
Date: Mon, 27 Feb 2017 15:18:52 +0100
Message-ID: <4940765.paEGL8zfci@xps13>
References: <1480205562-32745-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1484642507-15952-1-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 1B181591E
 for <dev@dpdk.org>; Mon, 27 Feb 2017 15:18:53 +0100 (CET)
Received: by mail-wm0-f51.google.com with SMTP id v186so62396860wmd.0
 for <dev@dpdk.org>; Mon, 27 Feb 2017 06:18:53 -0800 (PST)
In-Reply-To: <1484642507-15952-1-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-17 14:11, Jerin Jacob:
> This script generates cscope, gtags, and tags
> index files based on EAL environment.
> (architecture and OS(linux/bsd))
> 
> Selection of the architecture and OS environment
> is based on dpdk configuration target(T=)

What is the purpose of selecting a configuration?
Is it to go quicker in the implementation you are interested in?
In that case, I think we need a catch-all option, because I like
being prompted by vim that several implementations exist and I can
choose one of them.

> example usage:
> make tags T=x86_64-native-linuxapp-gcc
> make cscope T=x86_64-native-linuxapp-gcc
> make gtags T=x86_64-native-linuxapp-gcc
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
[...]
>  .gitignore        |   8 ++
>  devtools/tags.sh  | 251 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  mk/rte.sdkroot.mk |   4 +
>  3 files changed, 263 insertions(+)

I think build-tags.sh would be a better name.

On the implementation, I have few comments:
	- is there a way to re-use the skip list when including the related files?
	- you can remove tile from this patch
And for the details:
	- why a bash shebang where /bin/sh would be wider?
	- verbose option should be -v (with getopts)
	- please use $() instead of backquotes
	- please avoid one-line functions used only once like doctags

I can help you with this script if needed.