From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] pci: propagate exact error codes in pci_probe_all_drivers() Date: Mon, 29 Oct 2018 01:57:15 +0100 Message-ID: <4943602.Wu5sgN3NIT@xps> References: <20181026075459.21637-1-dariusz.stojaczyk@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Darek Stojaczyk Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CC79B91 for ; Mon, 29 Oct 2018 01:57:10 +0100 (CET) In-Reply-To: <20181026075459.21637-1-dariusz.stojaczyk@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/10/2018 09:54, Darek Stojaczyk: > In a couple of places we check its error code against -EEXIST, > but this function returned either -1, 0, or 1. > > This gets critical when hotplugging a device in secondary > process, while the same device is already plugged in the > primary. Failing to "hotplug" it in the primary will cause > the secondary to fail as well. > > Fixes: e9d159c3d534 ("eal: allow probing a device again") > Cc: thomas@monjalon.net > Cc: stable@dpdk.org No need of Cc: stable here. > Signed-off-by: Darek Stojaczyk Acked-by: Thomas Monjalon Applied, thanks