From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gaetan Rivet Subject: [PATCH v2 11/18] devargs: simplify implementation Date: Thu, 12 Oct 2017 10:21:18 +0200 Message-ID: <49446c2cba12cd5da276bfde8479aa97dcf0f653.1507796100.git.gaetan.rivet@6wind.com> References: Cc: Gaetan Rivet To: dev@dpdk.org Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 799861B1C1 for ; Thu, 12 Oct 2017 10:21:54 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id l68so10984617wmd.5 for ; Thu, 12 Oct 2017 01:21:54 -0700 (PDT) In-Reply-To: In-Reply-To: References: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Re-use existing code, remove incorrect comments. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 49cc3b8..1d87cd9 100644 --- a/lib/librte_eal/common/eal_common_devargs.c +++ b/lib/librte_eal/common/eal_common_devargs.c @@ -153,21 +153,19 @@ rte_eal_devargs_insert(struct rte_devargs *da) return 0; } -/* store a whitelist parameter for later parsing */ int -rte_eal_devargs_add(const char *devargs_str) +rte_eal_devargs_add(const char *dev) { struct rte_devargs *devargs = NULL; - const char *dev = devargs_str; - /* use calloc instead of rte_zmalloc as it's called early at init */ devargs = calloc(1, sizeof(*devargs)); if (devargs == NULL) goto fail; if (rte_eal_devargs_parse(devargs, "%s", dev)) goto fail; - TAILQ_INSERT_TAIL(&devargs_list, devargs, next); + if (rte_eal_devargs_insert(devargs)) + goto fail; return 0; fail: -- 2.1.4