From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 01/16] net/axgbe: add minimal dev init and
 uninit support
Date: Fri, 8 Dec 2017 13:04:25 -0800
Message-ID: <49533283-4355-4544-15e8-4c3308f1ba94@intel.com>
References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Ravi Kumar <Ravi1.kumar@amd.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 03776200
 for <dev@dpdk.org>; Fri,  8 Dec 2017 22:04:26 +0100 (CET)
In-Reply-To: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/30/2017 5:10 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

<...>

> +	/*
> +	 * For secondary processes, we don't initialise any further as primary
> +	 * has already done this work.
> +	 */
> +	if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
> +		PMD_DRV_LOG(ERR, "SECONDARY PROCCESS NOT SUPPORTED");
> +		return -EINVAL;

Do you want to return error here?
rte_eth_dev_pci_generic_probe() already calls rte_eth_dev_attach_secondary(),
just returning here can work for secondary process.

> +	}
> +	pci_dev = RTE_DEV_TO_PCI(eth_dev->device);
> +	pdata->pci_dev = pci_dev;
> +	rte_eth_copy_pci_info(eth_dev, pci_dev);

rte_eth_copy_pci_info() already called by rte_eth_dev_pci_generic_probe()

<...>

> +	eth_dev->dev_ops = NULL;
> +	eth_dev->rx_pkt_burst = NULL;
> +	eth_dev->tx_pkt_burst = NULL;
> +
> +	/*Clear macaddres at  time of dev init*/
> +	eth_dev->data->mac_addrs = NULL;
> +	eth_dev->data->hash_mac_addrs = NULL;

None of these set yet, you can add these when they are initiazed, and this helps
to trace matching init / unints.

<...>

> +#define PMD_INIT_LOG(level, fmt, args...) \
> +	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ##args)

Can you please swith this to dynamic logging, currently only i40e has sample
usage for it.

<...>

> @@ -0,0 +1,4 @@
> +DPDK_17.11 {

DPDK_18.02

<...>