From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 7/8] virtio/lib:add virtio guest offload
	capabilities
Date: Wed, 11 Nov 2015 11:08:10 +0100
Message-ID: <4986896.Ej2aoXBN66@xps13>
References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com>
 <20151111084419.GC2326@yliu-dev.sh.intel.com>
 <1ED644BD7E0A5F4091CF203DAFB8E4CC22BDA74A@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Michael S. Tsirkin" <mst@redhat.com>
To: "Liu, Jijiang" <jijiang.liu@intel.com>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id B0C88E72
 for <dev@dpdk.org>; Wed, 11 Nov 2015 11:09:22 +0100 (CET)
Received: by wmvv187 with SMTP id v187so48485377wmv.1
 for <dev@dpdk.org>; Wed, 11 Nov 2015 02:09:22 -0800 (PST)
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BDA74A@SHSMSX101.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-11-11 08:53, Liu, Jijiang:
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> > On Wed, Nov 11, 2015 at 08:38:29AM +0000, Liu, Jijiang wrote:
> > > According to virtio standard, those fileds should be set.
> > 
> > If so, you'd better quote them here, or even to your patch commit.
> 
> In the Virtual I/O Device (VIRTIO) Version 1.0 Committee Specification 02, 
> 
> (1) VIRTIO_NET_F_GUEST_CSUM (1) Driver handles packets with partial checksum.
> 
> (2) If the VIRTIO_NET_F_GUEST_CSUM feature was negotiated, the VIRTIO_NET_HDR_F_NEEDS_-
> CSUM bit in flags MAY be set: if so, the checksum on the packet is incomplete and csum_start
> and csum_offset indicate how to calculate it (see Packet Transmission point 1).
> 
> (3) If the VIRTIO_NET_F_GUEST_TSO4, TSO6 or UFO options were negotiated, then gso_type
> MAY be something other than VIRTIO_NET_HDR_GSO_NONE, and gso_size field indicates
> the desired MSS (see Packet Transmission point 2).
> 
> The information can be included in the next version of patch set.

Yes quoting specifications or datasheets in commit messages is a really good idea.
Thanks for improving the quality of the git history.