From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B75B9C433FF for ; Mon, 29 Jul 2019 20:01:42 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 46E1B20657 for ; Mon, 29 Jul 2019 20:01:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="inpqxpY1"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="X8IZJKic" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46E1B20657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3DEAF1BF53; Mon, 29 Jul 2019 22:01:41 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 3EE371BEF7; Mon, 29 Jul 2019 22:01:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9A0F52205C; Mon, 29 Jul 2019 16:01:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 29 Jul 2019 16:01:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=iAluzaJWNTZ4qMzCQbGDcfe6GLkWYkiHJMkSaScGdwg=; b=inpqxpY1B7gZ n1hjD9H6y1p4oFlph6HIplYclv6Wam45gNzGtUTt0X1GGCPO59Lr/G4xG2Hvu4IE pZ3SvpVx3AOVUWvajEEKCHZGs0iJZq+fwcB0E8fDRKJlml6mQwzIDS7Yd6zAsVR+ OnyCaQiYBxKdzlTTM1JeQjk3Iqi6OwU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=iAluzaJWNTZ4qMzCQbGDcfe6GLkWYkiHJMkSaScGd wg=; b=X8IZJKic+YWQDNqflIrgJNDSflZUOYU13D4HMM61m0P5Krfkcf1WAh188 6guK4UK+3sQkBpCGPGhA6jMTZjfPy1aH5GgDn2si8hkEdA/wjczBRmX/ek0uK4NU h62pM5mFzhgTPkaJs/TZ2qqBtv2pk4oZ91gTSgFdmnfLmKwni4tEy8XOOb5LmwvS i/rCe6tcMStjcu4dsEZv20NEwyZkAix0zpKMapPH0DtBE+2cLcabyswDsjehgKva XKH7Y5+TkVbbSDMnUhmXNZmZifqUzm1hht/8Xfj2E7kTff0dZBeCFA0FRiJcpaIv 9MBuLB3sYxGrPRJk2duC3eSOUmsiQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrledugddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B947980062; Mon, 29 Jul 2019 16:01:38 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org Date: Mon, 29 Jul 2019 22:01:37 +0200 Message-ID: <4993307.ozS7eDCDq7@xps> In-Reply-To: <20190729123216.64601-1-ferruh.yigit@intel.com> References: <20190729123216.64601-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix build on Linux 5.3 for implicit fall through X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/07/2019 14:32, Ferruh Yigit: > build error: > .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c: > In function =E2=80=98igbuio_pci_enable_interrupts=E2=80=99: > .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:230:6: > error: this statement may fall through > [-Werror=3Dimplicit-fallthrough=3D] > 230 | if (pci_alloc_irq_vectors(udev->pdev, 1, 1, .... > .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:240:2: > note: here > 240 | case RTE_INTR_MODE_MSI: > | ^~~~ >=20 > The build error is caused by Linux kernel commit in 5.3 that enables the > "-Wimplicit-fallthrough=3D3" gcc flag. > Commit a035d552a93b ("Makefile: Globally enable fall-through warning") >=20 > To fix the error, either a gcc attribute can be provided [1] or a code > comment with some defined syntax need to be provided [2], since there is > already comments, updated them slightly to match the required syntax to > fix the build error. >=20 > [1] > "__attribute__ ((fallthrough));" >=20 > [2] > [ \t.!]*([Ee]lse,? |[Ii]ntentional(ly)? )? > fall(s | |-)?thr(ough|u)[ \t.!]*(-[^\n\r]*)? >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit Applied, thanks