From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/1] remove unnecessray fw declarations
Date: Sun, 18 Nov 2018 23:45:58 +0100
Message-ID: <4993609.zzt5v1ZH8Z@xps>
References: <20180822143731.3971-1-ramirose@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, stable@dpdk.org
To: Rami Rosen <ramirose@gmail.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180822143731.3971-1-ramirose@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/08/2018 16:37, Rami Rosen:
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -435,9 +435,6 @@ static int eth_event_callback(portid_t port_id,
>  static void eth_dev_event_callback(char *device_name,
>  				enum rte_dev_event_type type,
>  				void *param);
> -static int eth_dev_event_callback_register(void);
> -static int eth_dev_event_callback_unregister(void);

I has been fixed by 2049c5113fe8 ("app/testpmd: use hotplug failure handler").

However I agree that some forward declarations could be removed,
ideally all.
Generally speaking, a lot of cleanup could be done in this file.