From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v2] add mtu set in virtio Date: Fri, 2 Sep 2016 09:05:49 +0200 Message-ID: <49bce2ef-ffbd-96ff-6f9c-6c37bb7c7a90@redhat.com> References: <20160829230240.20164-1-sodey@sonusnet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Dey, Souvik" , "stephen@networkplumber.org" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 099AFA6A for ; Fri, 2 Sep 2016 09:05:53 +0200 (CEST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Souvik, On 09/02/2016 12:20 AM, Dey, Souvik wrote: > Hi Maxime, > When is patches or new implementation going to come in the release ? if it is not 16.11 then, can we keep this change till the new virtio changes come in the release. And if it is already planned for 16.11, then can I get a little more information on that. > I'm currently working on qemu part implementation, first RFC should be sent next week. Goal is to have it in 16.11, but I cannot commit, as the spec update has not been acked yet. For more information, you can start by having a look at the spec review: https://lists.oasis-open.org/archives/virtio-dev/201608/msg00056.html Regards, Maxime > -- > Regards, > Souvik > > -----Original Message----- > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] > Sent: Tuesday, August 30, 2016 3:58 AM > To: Dey, Souvik ; stephen@networkplumber.org; huawei.xie@intel.com; yuanhan.liu@linux.intel.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] add mtu set in virtio > > Hi Souvik, > > On 08/30/2016 01:02 AM, souvikdey33 wrote: >> Signed-off-by: Souvik Dey >> >> Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey ") >> Reviewed-by: Stephen Hemminger >> >> Virtio interfaces should also support setting of mtu, as in case of >> cloud it is expected to have the consistent mtu across the >> infrastructure that the dhcp server sends and not hardcoded to 1500(default). >> --- >> drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > > FYI, there are some on-going changes in the VIRTIO specification so that the VHOST interface exposes its MTU to its VIRTIO peer. > It may also be used as an alternative of what you patch achieves. > > I am working on its implementation in Qemu/DPDK, our goal being to reduce performance drops for small packets with Rx mergeable buffers feature enabled. > > Regards, > Maxime >