From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 32/32] app/testpmd: fix invalid port ID Date: Wed, 7 Dec 2016 15:48:50 +0000 Message-ID: <49f75886-8149-4900-c948-ea75be694b11@intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-33-git-send-email-wenzhuo.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: "Chen Jing D(Mark)" To: Wenzhuo Lu , dev@dpdk.org Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 223E8388F for ; Wed, 7 Dec 2016 16:48:52 +0100 (CET) In-Reply-To: <1481081535-37448-33-git-send-email-wenzhuo.lu@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > Some CLIs don't check the input port ID, it > may cause segmentation fault (core dumped). Are these functions (that we are adding extra check) added with this patchset? If so why not add these checks where function implemented. If these functions are already implemented before this patchset, this patch can be standalone patch, instead of being part of this patchset, and can be before this patchset so that it can be easily backported to stable trees. > > Fixes: 425781ff5afe ("app/testpmd: add ixgbe VF management") > > Signed-off-by: Wenzhuo Lu > Signed-off-by: Chen Jing D(Mark) > --- <...>