From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [pktgen PATCH 0/6] fix compilation Date: Wed, 26 Jul 2017 03:54:23 +0000 Message-ID: <4FFF6FD7-FAAB-4034-92DC-D1CF27294837@intel.com> References: <20170725222107.23203-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id ECA021F5 for ; Wed, 26 Jul 2017 05:54:26 +0200 (CEST) In-Reply-To: <20170725222107.23203-1-thomas@monjalon.net> Content-Language: en-US Content-ID: <469B3CCB1B7A94469C86FFDF80CF6DE2@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jul 25, 2017, at 5:21 PM, Thomas Monjalon wrote: >=20 > Some errors were seen when trying to compile with gcc 7 or clang, > for 32-bit, and with DPDK 17.08-rc2. >=20 > Thomas Monjalon (6): > remove unused functions > fix screen type saving > fix compilation of printf based functions > fix compilation with gcc 7 > fix 32-bit build > fix build with dpdk-17.08-rc2 >=20 > app/Makefile | 3 --- > app/cli-functions.c | 2 +- > app/lpktgenlib.c | 12 ++---------- > app/pktgen-cmds.c | 18 +++++++++--------- > app/pktgen-latency.c | 26 ++++++++++++++------------ > app/pktgen-log.c | 1 + > app/pktgen-port-cfg.h | 2 +- > app/pktgen-stats.c | 47 ++++++++++++++++++++++++++++---------------= ---- > lib/cli/cli.c | 2 +- > lib/cli/cli_cmds.c | 6 +++--- > lib/cli/cli_common.h | 1 + > lib/cli/cli_map.c | 2 +- > lib/cli/cli_scrn.c | 5 ++++- > lib/cli/cli_scrn.h | 1 + > lib/common/l2p.c | 34 ---------------------------------- > lib/common/mbuf.h | 3 +++ > lib/common/port_config.c | 10 +--------- > 17 files changed, 71 insertions(+), 104 deletions(-) Acked by: Keith Wiles I did apply these changes and in testing with i40e Pktgen now only sends a = few thousand packets then stops sending. I am sure these patches are not th= e problem, but did you try out Pktgen to see if it worked with 17.08-rc2? W= hich version of Pktgen did you use? I tried with clang and gcc both behave the same. I noticed a new message: i40e_dev_start(): please call hierarchy_commit() before starting the port i40e_dev_start(): please call hierarchy_commit() before starting the port i40e_dev_start(): please call hierarchy_commit() before starting the port i40e_dev_start(): please call hierarchy_commit() before starting the port and I tried to add the call in pktgen, but it had no effect. To me the TM A= PI should be defaulted to the original mode and just work unless someone ne= eds to use the TM APIs. The hierarchy_commit routine could not need to be c= alled in the normal case is my guess. >=20 > --=20 > 2.13.2 >=20 Regards, Keith