From: Marat Khalili <qm2k21@gmail.com>
To: dev@dpdk.org
Subject: Re: [PATCH 0/6] provide a complete set of BSD list macros
Date: Fri, 18 Sep 2026 12:34:47 +0100 [thread overview]
Message-ID: <4aae7483-8b7c-4baf-bed7-f932fc0cce0b@gmail.com> (raw)
In-Reply-To: <20260917172116.660120-1-stephen@networkplumber.org>
The patch set generally looks good to me, and ensures that DPDK itself
builds. However, there might be a problem with building external
applications IIUC: if DPDK header using any of the macros missing in
system <sys/queue.h> is included after <sys/queue.h> the build will fail
for reasons not immediately clear to the user.
I think this specific case can be improved in one of the following ways:
1. Remove the _SYS_QUEUE_H_ guard and undef or guard each macro
independently (the file should still define _SYS_QUEUE_H_ to prevent the
converse failure).
2. Detect the situation described above and provide more helpful
diagnostic suggesting a workaround (remove <sys/queue.h> or move it
after DPDK headers).
I myself prefer #1, since swapping or removing includes might be
difficult in big projects.
next prev parent reply other threads:[~2026-09-18 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 17:19 [PATCH 0/6] provide a complete set of BSD list macros Stephen Hemminger
2026-09-17 17:19 ` [PATCH 1/6] net/bnxt: fix use after free when freeing filters Stephen Hemminger
2026-09-17 17:19 ` [PATCH 2/6] eal: add rte_queue.h with full set of list macros Stephen Hemminger
2026-09-17 17:19 ` [PATCH 3/6] build: use rte_queue.h instead of sys/queue.h Stephen Hemminger
2026-09-17 17:19 ` [PATCH 4/6] build: remove private FOREACH_SAFE definitions Stephen Hemminger
2026-09-17 17:19 ` [PATCH 5/6] eal: deprecate RTE_TAILQ and RTE_STAILQ macro wrappers Stephen Hemminger
2026-09-17 17:19 ` [PATCH 6/6] devtools: forbid direct use of sys/queue.h Stephen Hemminger
2026-09-18 11:34 ` Marat Khalili [this message]
2026-09-18 11:50 ` [PATCH 0/6] provide a complete set of BSD list macros Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aae7483-8b7c-4baf-bed7-f932fc0cce0b@gmail.com \
--to=qm2k21@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox