From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v1 1/9] mempool: add op to calculate memory
 size to be allocated
Date: Tue, 20 Mar 2018 13:29:11 +0300
Message-ID: <4ab1ccc5-53c0-afe0-9bac-bc61a54be38e@solarflare.com>
References: <1516713372-10572-1-git-send-email-arybchenko@solarflare.com>
 <1520696382-16400-1-git-send-email-arybchenko@solarflare.com>
 <1520696382-16400-2-git-send-email-arybchenko@solarflare.com>
 <20180319170352.ddwhimxr6dzkpqea@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 1462B4D3A
 for <dev@dpdk.org>; Tue, 20 Mar 2018 11:29:22 +0100 (CET)
In-Reply-To: <20180319170352.ddwhimxr6dzkpqea@platinum>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/19/2018 08:03 PM, Olivier Matz wrote:
> On Sat, Mar 10, 2018 at 03:39:34PM +0000, Andrew Rybchenko wrote:
>> --- a/lib/librte_mempool/Makefile
>> +++ b/lib/librte_mempool/Makefile
>> @@ -11,11 +11,12 @@ LDLIBS += -lrte_eal -lrte_ring
>>   
>>   EXPORT_MAP := rte_mempool_version.map
>>   
>> -LIBABIVER := 3
>> +LIBABIVER := 4
>>   
>>   # all source are stored in SRCS-y
>>   SRCS-$(CONFIG_RTE_LIBRTE_MEMPOOL) +=  rte_mempool.c
>>   SRCS-$(CONFIG_RTE_LIBRTE_MEMPOOL) +=  rte_mempool_ops.c
>> +SRCS-$(CONFIG_RTE_LIBRTE_MEMPOOL) +=  rte_mempool_ops_default.c
>>   # install includes
>>   SYMLINK-$(CONFIG_RTE_LIBRTE_MEMPOOL)-include := rte_mempool.h
>>   
>> diff --git a/lib/librte_mempool/meson.build b/lib/librte_mempool/meson.build
>> index 7a4f3da..9e3b527 100644
>> --- a/lib/librte_mempool/meson.build
>> +++ b/lib/librte_mempool/meson.build
>> @@ -1,7 +1,8 @@
>>   # SPDX-License-Identifier: BSD-3-Clause
>>   # Copyright(c) 2017 Intel Corporation
>>   
>> -version = 2
>> -sources = files('rte_mempool.c', 'rte_mempool_ops.c')
>> +version = 4
>> +sources = files('rte_mempool.c', 'rte_mempool_ops.c',
>> +		'rte_mempool_ops_default.c')
>>   headers = files('rte_mempool.h')
>>   deps += ['ring']
> It's strange to see that meson does not have the same
> .so version than the legacy build system.
>
> +CC Bruce in case he wants to fix this issue separately.

I'll make a patchset to fix all similar issues. It should be definitely 
separate
since it should be backported to 18.02.

I think main problem here is the version=1 default in the case of meson.
So, there are really many examples w/o version and it is simply 
lost/forgotten
when a new library is added to meson.