From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v7 4/4] ethdev: add shared counter support to
 rte_flow
Date: Fri, 27 Apr 2018 15:52:18 +0100
Message-ID: <4bfef610-0d04-75f1-6c53-da8c8f8f7917@intel.com>
References: <20180426120817.6612-1-declan.doherty@intel.com>
 <20180426172919.8450-1-declan.doherty@intel.com>
 <20180426172919.8450-5-declan.doherty@intel.com> <4407791.6t3C6RaO4r@xps>
 <6fc154a0-d802-9c83-1764-16410461b64c@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>,
 Declan Doherty <declan.doherty@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id F036C8D8F
 for <dev@dpdk.org>; Fri, 27 Apr 2018 16:52:22 +0200 (CEST)
In-Reply-To: <6fc154a0-d802-9c83-1764-16410461b64c@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/27/2018 1:25 PM, Ferruh Yigit wrote:
> On 4/26/2018 7:55 PM, Thomas Monjalon wrote:
>> 26/04/2018 19:29, Declan Doherty:
>>> Add rte_flow_action_count action data structure to enable shared
>>> counters across multiple flows on a single port or across multiple
>>> flows on multiple ports within the same switch domain. Also this enables
>>> multiple count actions to be specified in a single flow action.
>>>
>>> This patch also modifies the existing rte_flow_query API to take the
>>> rte_flow_action structure as an input parameter instead of the
>>> rte_flow_action_type enumeration to allow querying a specific action
>>> from a flow rule when multiple actions of the same type are specified.
>>>
>>> This patch also contains updates for the bonding, failsafe and mlx5 PMDs
>>> and testpmd application which are affected by this API change.
>>
>> The API changes must be notified in the release notes (there is a section
>> for API changes).
> 
> Hi Declan,
> 
> If you can send the update as a separate patch, I can squash it in next-net.

Thanks Declan, following addition squashed into related commit:

* ethdev: change flow APIs regarding count action:
  * ``rte_flow_create()`` API count action now requires the ``struct
rte_flow_action_count``.
  * ``rte_flow_query()`` API parameter changed from action type to action structure.