From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v6 1/5] ethdev: add access to eeprom
Date: Wed, 25 Apr 2018 11:40:37 +0100
Message-ID: <4c0acad4-f5f8-4eee-a6a4-827d348dfa86@intel.com>
References: <1524647624-23005-1-git-send-email-zijie.pan@6wind.com>
 <1524650515-26659-1-git-send-email-zijie.pan@6wind.com>
 <1524650515-26659-2-git-send-email-zijie.pan@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: remy.horton@intel.com, thomas@monjalon.net, john.mcnamara@intel.com,
 marko.kovacevic@intel.com
To: Zijie Pan <zijie.pan@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id BAA204F9A
 for <dev@dpdk.org>; Wed, 25 Apr 2018 12:40:40 +0200 (CEST)
In-Reply-To: <1524650515-26659-2-git-send-email-zijie.pan@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/25/2018 11:01 AM, Zijie Pan wrote:
> add new APIs:
> - rte_eth_dev_get_module_info
> - rte_eth_dev_get_module_eeprom
> 
> Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
> Acked-by: Remy Horton <remy.horton@intel.com>
> ---
> Cc: remy.horton@intel.com
> Cc: john.mcnamara@intel.com
> Cc: marko.kovacevic@intel.com
> Cc: thomas@monjalon.net
> 
>  doc/guides/nics/features.rst            |   11 ++++++++
>  lib/librte_ether/rte_dev_info.h         |   18 +++++++++++++
>  lib/librte_ether/rte_ethdev.c           |   26 +++++++++++++++++++
>  lib/librte_ether/rte_ethdev.h           |   43 +++++++++++++++++++++++++++++++
>  lib/librte_ether/rte_ethdev_core.h      |   12 +++++++++
>  lib/librte_ether/rte_ethdev_version.map |    2 ++
>  6 files changed, 112 insertions(+)
> 
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index 1b4fb97..bb183e2 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -749,6 +749,17 @@ Supports getting/setting device eeprom data.
>    ``rte_eth_dev_set_eeprom()``.
>  
>  
> +.. _nic_features_module_eeprom_dump:
> +
> +Module EEPROM dump
> +------------------
> +
> +Supports getting information and data of plugin module eeprom.
> +
> +* **[implements] eth_dev_ops**: ``get_module_info``, ``get_module_eeprom``.
> +* **[related]    API**: ``rte_eth_dev_get_module_info()``, ``rte_eth_dev_get_module_eeprom()``.
> +
> +

New feature added also needs to be added default.ini file, please replace this
feature somewhere close the related features in default.ini

And please keep Thomas' Ack for next version