From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] ethdev: replace bus specific struct with
 generic dev
Date: Fri, 30 Mar 2018 11:27:24 +0100
Message-ID: <4c20ec33-4cc4-a239-6f89-2f5ed58d69b1@intel.com>
References: <20180329145048.123662-1-ferruh.yigit@intel.com>
 <20180329175206.127943-1-ferruh.yigit@intel.com>
 <CALwxeUsO0g4QX64to_CWuOVL3pgQCmcqNRhS+Lmj_oEFov9igw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 48A4B27D
 for <dev@dpdk.org>; Fri, 30 Mar 2018 12:27:26 +0200 (CEST)
In-Reply-To: <CALwxeUsO0g4QX64to_CWuOVL3pgQCmcqNRhS+Lmj_oEFov9igw@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/30/2018 7:44 AM, David Marchand wrote:
> Hello Ferruh,
> 
> On Thu, Mar 29, 2018 at 7:52 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it
>> although it is common for all ethdev in all buses.
>>
>> Replacing pci specific struct with generic device struct and updating
>> places that are using pci device in a way to get this information from
>> generic device.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> Acked-by: Allain Legacy <allain.legacy@windriver.com>
>> Acked-by: Tomasz Duszynski <tdu@semihalf.com>
>> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> 
> The ethdev device already points to the backing device.
> So, can't this be done in the ethdev layer itself ?

Thanks Dave, yes, I think can be done. I will update according.

> 
>