From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent Date: Fri, 20 Apr 2018 01:10:23 +0100 Message-ID: <4d08acfb-57d7-a347-a772-3c268b49a3ff@intel.com> References: <20180318014552.16703-1-3chas3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: skhare@vmware.com, Chas Williams , stable@dpdk.org To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org Return-path: In-Reply-To: <20180318014552.16703-1-3chas3@gmail.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/18/2018 1:45 AM, Chas Williams wrote: > From: Chas Williams > > The vmxnet3 never attempts link speed negotiation. As a virtual device > the link speed is vague at best. However, it is important for certain > applications, like bonding, to see a consistent link_status. 802.3ad > requires that only links of the same cost (link speed) be enslaved. > Keeping the link status consistent in vmxnet3 avoids races with bonding > enslavement. > > Author: Thomas Monjalon > Date: Fri Jan 5 18:38:55 2018 +0100 > > Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value") > Cc: stable@dpdk.org > > Signed-off-by: Chas Williams >>From Thomas Monjalon : > Yes, OK for ETH_LINK_FIXED. >>From Yong Wang : > Yes and it makes sense for vmxnet3 to use ETH_LINK_FIXED. Converted into explicit ack: Acked-by: Yong Wang Applied to dpdk-next-net/master, thanks.