From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aviad Yehezkel <aviadye@dev.mellanox.co.il>
Subject: Re: [PATCH 05/11] examples/ipsec-secgw: Fixed transport
Date: Mon, 16 Oct 2017 13:42:26 +0300
Message-ID: <4db0dd77-e85c-8082-f450-a50c61b25e49@dev.mellanox.co.il>
References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il>
 <1507987683-12315-5-git-send-email-aviadye@dev.mellanox.co.il>
 <c9616a84-5eb9-7ce3-d9c5-c3d404936131@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: borisp@mellanox.com, akhil.goyal@nxp.com, hemant.agrawal@nxp.com,
 radu.nicolau@intel.com, declan.doherty@intel.com, liranl@mellanox.com,
 nelio.laranjeiro@6wind.com, thomas@monjalon.net
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>, dev@dpdk.org,
 pablo.de.lara.guarch@intel.com, aviadye@mellanox.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68])
 by dpdk.org (Postfix) with ESMTP id 691001B62E
 for <dev@dpdk.org>; Mon, 16 Oct 2017 12:42:36 +0200 (CEST)
Received: by mail-wm0-f68.google.com with SMTP id t69so1759921wmt.2
 for <dev@dpdk.org>; Mon, 16 Oct 2017 03:42:36 -0700 (PDT)
In-Reply-To: <c9616a84-5eb9-7ce3-d9c5-c3d404936131@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 10/16/2017 12:30 PM, Sergio Gonzalez Monroy wrote:
> On 14/10/2017 14:27, aviadye@dev.mellanox.co.il wrote:
>> From: Aviad Yehezkel <aviadye@mellanox.com>
>>
>> Seems like transport was broken for a long time
>
> Commit message needs to be improved. Just mentioned what is wrong or 
> how do you fix it.
> Given that it is a fix, you should start the commit title with "fix 
> ..." then also add the 'fixes' line with commit that added the bug.
> That way you can easily see since when it was introduced.
>
> Thanks,
> Sergio
Will create such commit messages for future fixes as you instructed above.
I will remove this patch from next version of fixes since there is a 
similar fix
already provided by Tomasz Duszynski which I will review.

Thanks,
Aviad.


>> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
>> ---
>>   examples/ipsec-secgw/esp.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c
>> index 70bb81f..56ad7a0 100644
>> --- a/examples/ipsec-secgw/esp.c
>> +++ b/examples/ipsec-secgw/esp.c
>> @@ -306,8 +306,8 @@ esp_outbound(struct rte_mbuf *m, struct ipsec_sa 
>> *sa,
>>                   sizeof(struct esp_hdr) + sa->iv_len);
>>           memmove(new_ip, ip4, ip_hdr_len);
>>           esp = (struct esp_hdr *)(new_ip + ip_hdr_len);
>> +        ip4 = (struct ip *)new_ip;
>>           if (likely(ip4->ip_v == IPVERSION)) {
>> -            ip4 = (struct ip *)new_ip;
>>               ip4->ip_p = IPPROTO_ESP;
>>               ip4->ip_len = htons(rte_pktmbuf_data_len(m));
>>           } else {
>
>