From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chas Williams <3chas3@gmail.com> Subject: Re: [dpdk-stable] [PATCH] net/bonding: fix reset active slave Date: Thu, 21 Feb 2019 20:52:27 -0500 Message-ID: <4de12ce5-fda5-520c-22ea-d693c5b0c2cd@gmail.com> References: <1550491163-23616-1-git-send-email-hari.kumarx.vemula@intel.com> <3d107ef4-576f-39b0-0e87-6b62e333fc6a@intel.com> <67490f9f-a3cb-3b75-f0d9-db323c4787e9@intel.com> <20190220151650.GA30988@HYONKIM-7R0DR.cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Ferruh Yigit , Hari Kumar Vemula , dev@dpdk.org, "Pattan, Reshma" , JananeeX M , Declan , stable@dpdk.org To: Hyong Youb Kim , Radu Nicolau Return-path: In-Reply-To: <20190220151650.GA30988@HYONKIM-7R0DR.cisco.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/20/19 10:16 AM, Hyong Youb Kim wrote: > On Wed, Feb 20, 2019 at 02:56:36PM +0000, Radu Nicolau wrote: >> >> >> On 2/20/2019 12:33 PM, Ferruh Yigit wrote: >>> On 2/18/2019 3:58 PM, Radu Nicolau wrote: >>>> >>>> On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: >>>>> test_alb_reply_from_client test fails due to incorrect active slave >>>>> array's index. This was due to invalid active slave count. >>>>> >>>>> Count of internals->active_slave is not updated even when active slave >>>>> is deactivated. >>>>> Hence active slave count always keeps incrementing beyond the actual >>>>> active slaves. >>>>> >>>>> Fix is to set the internals->active_slave to starting index 0 whenever >>>>> it exceeds the number of slaves in active slave list and also update >>>>> the active slave count during slave de-activation. >>>>> >>>>> Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Hari Kumar Vemula >>>>> --- >>>>> >>>> Acked-by: Radu Nicolau >>>> > >>> Hi Radu, Hari, >>> >>> There is another bonding patch, can you please check how related are they and if >>> are these fixing same root cause: >>> >>> net/bonding: avoid the next active slave going out of bound >>> https://patches.dpdk.org/patch/49573/ >>> >> Hi, it's a similar fix for the same root cause, but this one covers more (or >> all) situations that can cause active_slave to go out of bounds. > > If it covers more cases, please go with the new patch and drop mine. I > just want to see the issue fixed :-) Yes, it does cover a few more cases. There really isn't any coordination between slave activation/deactivation and the rx/tx burst routines. So checking at the beginning or the end of the various routines is about the same. > Thanks. > -Hyong >