From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 3/7] cxgbe: add support to update RSS hash
 configuration and key
Date: Mon, 5 Feb 2018 17:09:55 +0000
Message-ID: <4e2eda5f-4697-906e-0596-84502add0af6@intel.com>
References: <cover.1517685185.git.rahul.lakkireddy@chelsio.com>
 <713e92d0143827f8af409763815cde15b9d40305.1517685185.git.rahul.lakkireddy@chelsio.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: kumaras@chelsio.com, surendra@chelsio.com, nirranjan@chelsio.com,
 indranil@chelsio.com
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id D2B071B3F1
 for <dev@dpdk.org>; Mon,  5 Feb 2018 18:09:58 +0100 (CET)
In-Reply-To: <713e92d0143827f8af409763815cde15b9d40305.1517685185.git.rahul.lakkireddy@chelsio.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/4/2018 6:06 AM, Rahul Lakkireddy wrote:
> From: Kumar Sanghvi <kumaras@chelsio.com>
> 
> Add firmware API for updating RSS hash configuration and key.  Move
> RSS hash configuration from cxgb4_write_rss() to a separate function
> cxgbe_write_rss_conf().
> 
> Also, rename cxgb4_write_rss() to cxgbe_write_rss() for consistency.
> 
> Original work by Surendra Mobiya <surendra@chelsio.com>
> 
> Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> ---
>  doc/guides/nics/cxgbe.rst               |  2 +
>  doc/guides/nics/features/cxgbe.ini      |  1 +
>  doc/guides/rel_notes/release_18_02.rst  |  3 ++
>  drivers/net/cxgbe/base/adapter.h        |  4 +-
>  drivers/net/cxgbe/base/common.h         |  3 ++
>  drivers/net/cxgbe/base/t4_hw.c          | 73 +++++++++++++++++++++++++++
>  drivers/net/cxgbe/base/t4_regs.h        | 25 +++++++++
>  drivers/net/cxgbe/base/t4fw_interface.h | 89 +++++++++++++++++++++++++++++++++
>  drivers/net/cxgbe/cxgbe.h               |  2 +
>  drivers/net/cxgbe/cxgbe_ethdev.c        | 32 ++++++++++++
>  drivers/net/cxgbe/cxgbe_main.c          | 79 ++++++++++++++++++++++-------
>  11 files changed, 295 insertions(+), 18 deletions(-)

I tend to get driver patches even after integration deadline, mainly because of
their limited scope.
But since these are new features, submitted just before rc3, adding with
questions in first patch, I am for postponing this patchset to next release and
do more review, what do you think?