From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John Daley (johndale)" Subject: Re: [PATCH 37/41] net/enic: use contiguous allocation for DMA memory Date: Mon, 5 Mar 2018 19:45:07 +0000 Message-ID: <4e37f47997324f8b92bfefc10f4e05fc@XCH-RCD-007.cisco.com> References: <02c5ec20a2faa96f18dc58f869a330475c0bb018.1520083504.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Hyong Youb Kim (hyonkim)" To: Anatoly Burakov , "dev@dpdk.org" Return-path: Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by dpdk.org (Postfix) with ESMTP id 299FD2C18 for ; Mon, 5 Mar 2018 20:45:09 +0100 (CET) In-Reply-To: <02c5ec20a2faa96f18dc58f869a330475c0bb018.1520083504.git.anatoly.burakov@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anatoly, Looks good, see inline for details. Acked-by: John Daley Thanks, John > -----Original Message----- > From: Anatoly Burakov [mailto:anatoly.burakov@intel.com] > Sent: Saturday, March 03, 2018 5:46 AM > To: dev@dpdk.org > Cc: John Daley (johndale) ; Hyong Youb Kim (hyonkim) > ; keith.wiles@intel.com; jianfeng.tan@intel.com; > andras.kovacs@ericsson.com; laszlo.vadkeri@ericsson.com; > benjamin.walker@intel.com; bruce.richardson@intel.com; > thomas@monjalon.net; konstantin.ananyev@intel.com; > kuralamudhan.ramakrishnan@intel.com; louise.m.daly@intel.com; > nelio.laranjeiro@6wind.com; yskoh@mellanox.com; pepperjo@japf.ch; > jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; > olivier.matz@6wind.com > Subject: [PATCH 37/41] net/enic: use contiguous allocation for DMA memory >=20 > Signed-off-by: Anatoly Burakov > --- >=20 > Notes: > It is not 100% clear that second call to memzone_reserve > is allocating DMA memory. Corrections welcome. The 2nd call is allocating DMA memory so I believe your patch is correct. >=20 > drivers/net/enic/enic_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c = index > ec9d343..cb2a7ba 100644 > --- a/drivers/net/enic/enic_main.c > +++ b/drivers/net/enic/enic_main.c > @@ -319,7 +319,7 @@ enic_alloc_consistent(void *priv, size_t size, > struct enic *enic =3D (struct enic *)priv; > struct enic_memzone_entry *mze; >=20 > - rz =3D rte_memzone_reserve_aligned((const char *)name, > + rz =3D rte_memzone_reserve_aligned_contig((const char *)name, > size, SOCKET_ID_ANY, 0, > ENIC_ALIGN); > if (!rz) { > pr_err("%s : Failed to allocate memory requested for %s\n", > @@ -787,7 +787,7 @@ int enic_alloc_wq(struct enic *enic, uint16_t queue_i= dx, > "vnic_cqmsg-%s-%d-%d", enic->bdf_name, queue_idx, > instance++); >=20 > - wq->cqmsg_rz =3D rte_memzone_reserve_aligned((const char *)name, > + wq->cqmsg_rz =3D rte_memzone_reserve_aligned_contig((const char > *)name, > sizeof(uint32_t), > SOCKET_ID_ANY, 0, > ENIC_ALIGN); This is a send completion landing spot which is DMA'd to by the NIC so it d= oes have to be contiguous. However the size is only 4 bytes so it might not= matter. > -- > 2.7.4