From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v1 0/4] Generalize PCI specific EAL function/structures Date: Mon, 3 Oct 2016 11:07:43 +0530 Message-ID: <4e8b181f-8d46-f4b4-3821-a19f5c622ec1@nxp.com> References: <1472704915-13112-1-git-send-email-shreyansh.jain@nxp.com> <1474985551-14219-1-git-send-email-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Jan Viktorin , Thomas Monjalon To: David Marchand Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0040.outbound.protection.outlook.com [104.47.42.40]) by dpdk.org (Postfix) with ESMTP id 32E9F5A0A for ; Mon, 3 Oct 2016 07:36:56 +0200 (CEST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, On Friday 30 September 2016 09:01 PM, David Marchand wrote: > On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain wrote: >> (I rebased these over HEAD 7b3c4f3) >> >> These patches were initially part of Jan's original series on SoC >> Framework ([1],[2]). An update to that series, without these patches, >> was posted here [3]. >> >> Main motivation for these is aim of introducing a non-PCI centric >> subsystem in EAL. As of now the first usecase is SoC, but not limited to >> it. >> >> 4 patches in this series are independent of each other, as well as SoC >> framework. All these focus on generalizing some structure or functions >> present with the PCI specific code to EAL Common area (or splitting a >> function to be more userful). > > Those patches move linux specifics (binding pci devices using sysfs) > to common infrastucture. > We have no proper hotplug support on bsd, but if we had some common > code we should at least try to make the apis generic. > I am not sure if I understood your point well. Just to confirm - you are stating that the movement done in the patches might not suit BSD. Probably you are talking about (Patch 3/4 and 4/4). Is my understanding correct? So, movement to just Linux area is not enough? I am not well versed with BSD way of doing something similar so if someone can point it out, I can integrate that. (I will investigate it at my end as well). This patchset makes the PCI->EAL movement *only* for Linux for sysfs bind/unbind. (I should add this to cover letter, at the least). - Shreyansh