From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 3/3] app/testpmd: set packet dump based on
 verbosity level
Date: Thu, 11 Oct 2018 16:00:27 +0100
Message-ID: <4e8df067-0569-4b6f-3db6-ae080ff507b6@intel.com>
References: <1537793304-27883-1-git-send-email-rasland@mellanox.com>
 <1538897848-1693-1-git-send-email-rasland@mellanox.com>
 <1538897848-1693-3-git-send-email-rasland@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>,
 Shahaf Shuler <shahafs@mellanox.com>,
 "Xueming(Steven) Li" <xuemingl@mellanox.com>, Ori Kam <orika@mellanox.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 "david.marchand@6wind.com" <david.marchand@6wind.com>,
 "bernard.iremonger@intel.com" <bernard.iremonger@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>,
 "jingjing.wu@intel.com" <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id DF74F1B593
 for <dev@dpdk.org>; Thu, 11 Oct 2018 17:00:37 +0200 (CEST)
In-Reply-To: <1538897848-1693-3-git-send-email-rasland@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/7/2018 8:38 AM, Raslan Darawsheh wrote:
> when changing verbosity level it will configure rx/tx callbacks to dump
> packets based on the verbosity value as following:
>     1- dump only received packets:
>        testpmd> set verbose 1
>     2- dump only sent packets:
>        testpmd> set verbose 2
>     3- dump sent and received packets:
>        testpmd> set verbose (any number > 2)
>     4- disable dump
>        testpmd> set verbose 0

It is good to able to enable Rx/Tx separately but you are overloading "verbose"
meaning here. "verbose" is kind of log_level internal to testpmd and can be used
by many testpmd debug log.

Why not create a separate setting for it, perhaps like pkt_verbose?