From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Santana Francisco Subject: Re: [PATCH v6 1/1] ci: Introduce travis builds for github repositories Date: Thu, 21 Mar 2019 11:45:27 -0400 Message-ID: <4e9ca415-3bda-9250-2d62-90efa4fd747c@redhat.com> References: <20190207220114.8020-1-msantana@redhat.com> <20190304161232.5670-1-msantana@redhat.com> <20190304161232.5670-2-msantana@redhat.com> <9486436.3HrUK5duha@xps> <8cc57d73-bb0e-7f42-aa45-ffc5ab6abbf7@redhat.com> Reply-To: msantana@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Bruce Richardson , Honnappa Nagarahalli To: Luca Boccassi , Thomas Monjalon , Aaron Conole Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 68BA61B51E for ; Thu, 21 Mar 2019 16:45:29 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/20/19 5:11 PM, Luca Boccassi wrote: > On Wed, 2019-03-20 at 15:28 -0400, Michael Santana Francisco wrote: >>>> +matrix: >>>> + include: >>>> + - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1 >>>> + compiler: gcc >>>> + addons: >>>> + apt: >>>> + packages: >>>> + - [libnuma-dev, linux-headers-$(uname -r), python3- >>>> setuptools, python3-wheel, python3-pip, ninja-build] >>>> + - [gcc-aarch64-linux-gnu, libc6-dev-arm64-cross] >>> Why packages are repeated here again? >>> (sorry, I don't know Travis and I want to understand) >> Yeah, we don't want to repeat ourselves either but we have no >> choice. >> This is due to a limitation in travis. >> This matrix does not inherit any packages from the main package list >> way >> above, which means we have to list them out manually here. >> In addition to the required packages we also want to install full >> builds >> with libraries like libbsd-dev, libpcap-dev, etc. >> We could of just put those libraries in the main package list above >> and >> put all the builds in the env: list because then the libraries would >> be >> inherited. >> The problem with that is that is that travis would not keep minimal >> builds and full builds separate. >> We could not have minimal builds because the minimal builds will >> also >> inherit the additional libraries; Meson will then automatically >> detect >> those additional libraries and builds with them. >> What we would like to have is a way to tell meson which libraries we >> want to use and which we dont, instead of being auto-detected. This >> would help us to get rid of this matrix. >> >> If someone knows a better way to do this we would greatly take in >> your >> ideas, but so far this is the best we could come up with > It's yaml so you can write the list to a variable once and reference it > multiple times for brevity, see for example: > > https://github.com/zeromq/czmq/blob/master/.travis.yml#L128 > Thank you Luca! I had previously tested this approach and then it wasn't working the way I was hoping it would. I just finished testing it again and it seems to be working correctly this time! I got it working with the required packages in one list and use a variable to reference to that list. Next I will see about having a list for extra packages, and another for ARM packages Again, thank you! Will work on it