From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] kni: dynamically allocate memory for each
 KNI
Date: Tue, 2 Oct 2018 14:27:47 +0100
Message-ID: <4f3016d9-0983-eeb1-8310-e700a18b6dca@intel.com>
References: <20180923191202.64896-1-iryzhov@nfware.com>
 <20180926162106.1129-1-iryzhov@nfware.com> <4313273.d4aErm0F2p@xps>
 <554bb0ff-2aa6-6777-74d6-d6499657c54a@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>, Igor Ryzhov <iryzhov@nfware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 9CFF34CA0
 for <dev@dpdk.org>; Tue,  2 Oct 2018 15:27:49 +0200 (CEST)
In-Reply-To: <554bb0ff-2aa6-6777-74d6-d6499657c54a@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/2/2018 2:27 PM, Ferruh Yigit wrote:
> On 10/2/2018 2:06 PM, Thomas Monjalon wrote:
>> Hi,
>>
>> 26/09/2018 18:21, Igor Ryzhov:
>>> Long time ago preallocation of memory for KNI was introduced in commit
>>> 0c6bc8e. It was done because of lack of ability to free previously
>>> allocated memzones, which led to memzone exhaustion. Currently memzones
>>> can be freed and this patch uses this ability for dynamic KNI memory
>>> allocation.
>>>
>>> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
>>
>> The patch does not apply on master.
>> Is there a dependency?
> 
> There should not be a conflict, following commit already in tree is causing the

There should not be a _dependency_, ...

> conflict, I was resolving it myself when testing:
> Commit e716b639856c ("kni: fix crash with null name")
> 
> Basically both do same thing:
>  <<<<<<< IN REPO
>          if (name == NULL || name[0] == '\0')
>                  return NULL;
>  =======
>          if (!name || !name[0])
>                  return NULL;
>  >>>>>>> PATCH
> 
> 
> It seems Igor has a older version of the tree. It is OK to keep the check
> existing in the repo.
>