From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id F38B7C61DB9 for ; Fri, 28 Aug 2026 13:09:25 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8130440431; Fri, 28 Aug 2026 15:07:44 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 7898340B95 for ; Fri, 28 Aug 2026 15:07:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787922459; x=1819458459; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=36t/+6tp+OMnGirkVC8F1HOekMs+awgzQw0lym82Yco=; b=fcv2JDvvaNmtxSxMwQVpnXoZYqZj7t21kQB3THRmMfEwr0xUxSxCTa0/ lSkcdUcagWH/ZZhKt2Y9LCEcKMPMmPSdiPXF2o6tNspyBNtYD1cDwg2WQ dDWYOpm4Xp7qeeMXlt+hAxrBsL3zsq+TKcV/MnfGORMDiMCio2jIwE0OP yDmAi8PPLor9Sm+WQxyKYgv9d70nu4M8eF2goDCZl0yTwr8wF8I//h+Pn shXArOkiOXqmfsgyGUnJA0+Sq5lGbCtIKgcGA5OCO0qmNi/iU9w49lAIs KRpJG/AEehdcy23KZlRQDQCIiBSjc+6Qed0p9Hn2XYLxGKgF9bXt9go9Z g==; X-CSE-ConnectionGUID: LOe6wYeZScKsmkTIfEjKfA== X-CSE-MsgGUID: sqNfmGj2TD2+0yAPUCGxHg== X-IronPort-AV: E=McAfee;i="6800,10657,11888"; a="113964635" X-IronPort-AV: E=Sophos;i="6.25,248,1779174000"; d="scan'208";a="113964635" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2026 06:07:38 -0700 X-CSE-ConnectionGUID: ZiNX3Km6RUi8JoMLB7CUXA== X-CSE-MsgGUID: c6KZkfkxTF6+UqAWyj8KUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,248,1779174000"; d="scan'208";a="271960182" Received: from silpixa00401119.ir.intel.com ([10.20.224.206]) by orviesa004.jf.intel.com with ESMTP; 28 Aug 2026 06:07:37 -0700 From: Anatoly Burakov To: dev@dpdk.org, Hemant Agrawal , Sachin Saxena Subject: [PATCH v14 21/25] bus/fslmc: use the new VFIO mode API Date: Fri, 28 Aug 2026 14:06:49 +0100 Message-ID: <4fb32238eef176372e376df0d1c1a4086d505820.1787922363.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org FSLMC bus only supports operating in group mode, and relies on no-IOMMU mode checks. Use the new VFIO API's to query no-IOMMU status, as well as protect the bus from initializing in non-group mode. Signed-off-by: Anatoly Burakov Acked-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_bus.c | 11 ++++++++++- drivers/bus/fslmc/fslmc_vfio.c | 2 +- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index d55c414ead..8bfbdac52e 100644 --- a/drivers/bus/fslmc/fslmc_bus.c +++ b/drivers/bus/fslmc/fslmc_bus.c @@ -332,6 +332,14 @@ rte_fslmc_scan(void) goto scan_fail; } + /* for container groups to work, VFIO must be in group mode */ + if (dev_vfio_get_mode() != DEV_VFIO_MODE_GROUP && + dev_vfio_get_mode() != DEV_VFIO_MODE_NOIOMMU) { + DPAA2_BUS_DEBUG("DPAA2: VFIO not in group mode"); + ret = -EINVAL; + goto scan_fail; + } + ret = fslmc_get_container_group(group_name, &groupid); if (ret != 0) goto scan_fail; @@ -500,7 +508,8 @@ rte_dpaa2_get_iommu_class(void) return RTE_IOVA_DC; /* check if all devices on the bus support Virtual addressing or not */ - if (fslmc_all_device_support_iova() != 0 && dev_vfio_noiommu_is_enabled() == 0) + if (fslmc_all_device_support_iova() != 0 && + dev_vfio_get_mode() != DEV_VFIO_MODE_NOIOMMU) return RTE_IOVA_VA; return RTE_IOVA_PA; diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c index c2b6ac1f3f..c416ef9f68 100644 --- a/drivers/bus/fslmc/fslmc_vfio.c +++ b/drivers/bus/fslmc/fslmc_vfio.c @@ -204,7 +204,7 @@ fslmc_vfio_add_group(int vfio_group_fd, group->fd = vfio_group_fd; group->groupid = iommu_group_num; rte_strscpy(group->group_name, group_name, sizeof(group->group_name)); - if (dev_vfio_noiommu_is_enabled() > 0) + if (dev_vfio_get_mode() == DEV_VFIO_MODE_NOIOMMU) group->iommu_type = VFIO_NOIOMMU_IOMMU; else group->iommu_type = VFIO_TYPE1_IOMMU; -- 2.52.0