From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 0/8] link bonding Date: Sun, 23 Nov 2014 14:40:43 +0100 Message-ID: <5038013.rIESZ4PvDY@xps13> References: <1413291597-27326-1-git-send-email-declan.doherty@intel.com> <345C63BAECC1AD42A2EC8C63AFFC3ADC27422D1C@IRSMSX101.ger.corp.intel.com> <3280901.SpGJMfTadq@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Doherty, Declan" Return-path: In-Reply-To: <3280901.SpGJMfTadq@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-11-21 19:36, Thomas Monjalon: > 2014-11-21 17:07, Doherty, Declan: > > Hey Thomas, have you had a chance to have a look at this patchset, if you > > have any comments or issues can you let me know asap, as the patch sets for > > link bonding modes 4 & 5 are dependent on this set and I don't want to be > > blocking them from the next release candidate. > > Declan, your patchset doesn't touch anything else than the bonding area > (except socket_id parameter in testpmd), it is acked and it has a test > report since today. > You are the author (and implicit maintainer) of bonding, so I consider > I don't need to review this patchset. > > Conclusion: yes, it should be applied shortly. Actually no, checkpatch says this patchset is not ready. Some errors: TYPO_SPELLING: 'interupt' may be misspelled - perhaps 'interrupt'? TYPO_SPELLING: 'addres' may be misspelled - perhaps 'address'? BRACES: braces {} are not necessary for single statement blocks SPACING: space prohibited before semicolon MISSING_SPACE: break quoted strings at a space character TRAILING_SEMICOLON: macros should not use a trailing semicolon SPACING: space prohibited after that open parenthesis '(' Please fix and send a v7. Thanks -- Thomas