From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF Date: Wed, 10 May 2017 17:18:05 +0200 Message-ID: <5042107.JggcIGmKYW@xps> References: <1494399602-33955-1-git-send-email-wei.dai@intel.com> <8ad4912d-05d5-fdad-8bb5-a3e414c45738@cisco.com> <59130895.90503@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Laurent Hardy , "Roger B. Melton" , Ferruh Yigit , wenzhuo.lu@intel.com, konstantin.ananyev@intel.com To: Wei Dai Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id AFFB81C00 for ; Wed, 10 May 2017 17:18:06 +0200 (CEST) In-Reply-To: <59130895.90503@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/05/2017 14:33, Laurent Hardy: > Hi Ferruh, Wei, Roger, > PSB > I also redo test plan provided through > http://dpdk.org/dev/patchwork/patch/20502/ > > Thanks & regards, > Laurent > > On 05/10/2017 02:20 PM, Roger B. Melton wrote: > > > > > > On 5/10/17 5:50 AM, Ferruh Yigit wrote: > >> On 5/10/2017 8:00 AM, Wei Dai wrote: > >>> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not > >>> be called directly. It had better be replaced by calling > >>> ixgbe_get_media_type( ) to avoid crash. > >>> > >>> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") > >>> Cc: stable@dpdk.org > >>> > >>> Signed-off-by: Wei Dai > Acked-by: Laurent Hardy Removing stable@dpdk.org as the bug was introduced in 17.05-rc3. Applied, thanks