From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] hash: fix out-of-bound write while freeing
	key slot
Date: Fri, 21 Dec 2018 01:47:18 +0100
Message-ID: <5048136.3VFI2TIjne@xps>
References: <20181122025156.42217-1-honnappa.nagarahalli@arm.com>
 <20181220135917.GA13596@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 pablo.de.lara.guarch@intel.com, yipeng1.wang@intel.com, gavin.hu@arm.com,
 nd@arm.com
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 790504CA9
 for <dev@dpdk.org>; Fri, 21 Dec 2018 01:47:21 +0100 (CET)
In-Reply-To: <20181220135917.GA13596@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/12/2018 14:59, Bruce Richardson:
> On Wed, Nov 21, 2018 at 08:51:56PM -0600, Honnappa Nagarahalli wrote:
> > Add a debug check for out-of-bound write while freeing the key slot.
> > 
> > Coverity issue: 325733
> > Fixes: e605a1d36ca7 ("hash: add lock-free r/w concurrency")
> > Cc: honnappa.nagarahalli@arm.com
> > 
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Steve Capper <steve.capper@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> >  lib/librte_hash/rte_cuckoo_hash.c |  4 ++++
> >  lib/librte_hash/rte_cuckoo_hash.h | 11 +++++++++++
> >  2 files changed, 15 insertions(+)
> > 
> While I think enqueuing a free slot should ever fail, I don't see an issue
> with having a check for that.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks