From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: fix off-by-one error in hotplug add
Date: Fri, 04 Aug 2017 18:12:02 +0200
Message-ID: <5052998.tBGEROTkJq@xps>
References: <1501860623-16747-1-git-send-email-gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0AFFF235
 for <dev@dpdk.org>; Fri,  4 Aug 2017 18:12:04 +0200 (CEST)
In-Reply-To: <1501860623-16747-1-git-send-email-gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/08/2017 17:30, Gaetan Rivet:
> snprintf returns the length it would have written had the given length
> been enough, *terminating null byte excluded*.
> 
> It will however limit the length of its writing to given length minus
> one, and always put a terminating null-byte at the end of the string.
> 
> This must be taken into account when calculating the total length of the
> device declaration string.
> 
> Fixes: 3054036f054a ("eal: fix possible crash in hotplug")
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> 
> Charybdis -> Scylla

Oiseau de mauvais augure :)
The best is the enemy of the good.

Applied, thanks