From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 2/5] cfgfile: change existing API functions
Date: Tue, 19 Sep 2017 23:26:46 +0200
Message-ID: <5053892.oD5KOMONjY@xps>
References: <1505819248-19792-1-git-send-email-kubax.kozak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, deepak.k.jain@intel.com,
 michalx.k.jastrzebski@intel.com, jacekx.piasecki@intel.com
To: Kuba Kozak <kubax.kozak@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1D2DDF04
 for <dev@dpdk.org>; Tue, 19 Sep 2017 23:26:49 +0200 (CEST)
In-Reply-To: <1505819248-19792-1-git-send-email-kubax.kozak@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

19/09/2017 13:07, Kuba Kozak:
> @@ -409,7 +407,11 @@ rte_cfgfile_section_num_entries(struct rte_cfgfile *cfg,
>  {
>  	const struct rte_cfgfile_section *s = _get_section(cfg, sectionname);
>  	if (s == NULL)
> +#ifdef RTE_NEXT_ABI
> +		return -EINVAL;
> +#else
>  		return -1;
> +#endif
>  	return s->num_entries;
>  }

Why are you using RTE_NEXT_ABI?
Can you wait 18.02 to make this change?

Anyway, when breaking the API you need to update tha API section
of the release notes.

> @@ -219,7 +219,7 @@ int rte_cfgfile_section_num_entries_by_index(struct rte_cfgfile *cfg,
>  * @param max_entries
>  *   Maximum number of section entries to be stored in entries array
>  * @return
> -*   Number of entries populated on success, -1 otherwise
> +*   Number of entries populated on success, -EINVAL otherwise
>  */

This documentation become wrong if RTE_NEXT_ABI is disabled.