From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] eal: Clean up export of per_lcore__socket_id Date: Mon, 02 Mar 2015 19:41:50 +0100 Message-ID: <5054941.fYjsyoJciO@xps13> References: <1424874849-8973-1-git-send-email-nhorman@tuxdriver.com> <1425040393-31201-1-git-send-email-nhorman@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Neil Horman Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > > Theres no need to export this variable. Its set and queried from an API call > > that doesn't exist in the hot path. Instead just export the rte_socket_id > > symbol and make the variable private to protect it from type changes. We should > > do this with the other exported variables too, but I think its too late in the > > release cycle to do that. > > > > tested using distributor_autotest (which uses rte_socket_id), successfully. > > Only tested on linux, as I don't currently have a bsd system spun up, but the > > changes are symmetric, and should be fine > > > > Signed-off-by: Neil Horman > > Acked-by: Cunming Liang Applied, thanks