From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] mbuf: fix bulk allocation when debug
	enabled
Date: Wed, 10 May 2017 16:54:22 +0200
Message-ID: <5059101.zxD7I1FFNd@xps>
References: <1802735.EECn92tGJO@polaris> <20170510164235.62fcb469@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Gregory Etelson <gregory@weka.io>
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A6C0714EC
 for <dev@dpdk.org>; Wed, 10 May 2017 16:54:23 +0200 (CEST)
In-Reply-To: <20170510164235.62fcb469@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/05/2017 16:42, Olivier Matz:
> Hi,
> 
> On Sat, 06 May 2017 10:26:49 +0300, Gregory Etelson <gregory@weka.io> wrote:
> > The debug assertions when allocating a raw mbuf are not correct since
> > commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool"),
> > which triggers a panic when using this function in debug mode
> > 
> 
> Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> 
> > Signed-off-by: Gregory Etelson <gregory@weka.io>
> > ---
> >  lib/librte_mbuf/rte_mbuf.h | 25 ++++++++++++-------------
> >  1 file changed, 12 insertions(+), 13 deletions(-)
> > 
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> > index 9097f18..05b8300 100644
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbuf.h
> > @@ -788,6 +788,13 @@ rte_mbuf_refcnt_set(struct rte_mbuf *m, uint16_t new_value)
> >  void
> >  rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header);
> >  
> > +#define MBUF_RAW_ALLOC_CHECK(m_) do {				\
> > +	RTE_ASSERT(rte_mbuf_refcnt_read(m_) == 1);		\
> > +	RTE_ASSERT(m_->next == NULL);				\
> > +	RTE_ASSERT(m_->nb_segs == 1);				\
> > +	__rte_mbuf_sanity_check(m_, 0);				\
> > +} while (0)
> > +
> 
> Few nits:
> - maybe 'm_' could be 'm'
> - some parenthesis could be added for safety
> 
> Thomas, I know you're in hurry for 17.05, I think this fix should
> go in. If you want, I can send a v3 with this small changes if you
> need it now.

Yes, please a quick v3 would be appreciated.
Thanks