From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] doc: update ethdev APIs to return named
	opaque type
Date: Wed, 14 Feb 2018 18:10:44 +0100
Message-ID: <50628242.XRkpFPbRgn@xps>
References: <20180209101119.69860-1-ferruh.yigit@intel.com>
 <20180210120229.GB7298@jerin> <2b154134-d1e5-f7db-e38f-43900b48f91e@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>,
 Neil Horman <nhorman@tuxdriver.com>, "Mcnamara,
 John" <john.mcnamara@intel.com>, "Kovacevic,
 Marko" <marko.kovacevic@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>, "Richardson,
 Bruce" <bruce.richardson@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id C8F821B293
 for <dev@dpdk.org>; Wed, 14 Feb 2018 18:10:56 +0100 (CET)
In-Reply-To: <2b154134-d1e5-f7db-e38f-43900b48f91e@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> >>> Ethdev APIs to add callback return the callback object as "void *",
> >>> update return type to actual object type
> >>> "struct rte_eth_rxtx_callback *"
> >>>
> >>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>> ---
> >>> +* ethdev: functions add rx/tx callback will return named opaque type
> >>> +  rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and
> >>> +  rte_eth_add_tx_callback() functions currently return callback object as
> >>> +  "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*"
> >>> +  as parameter. For consistency functions adding callback will return
> >>> +  "struct rte_eth_rxtx_callback \*" instead of "void * ".
> >>> +
> >>>   * i40e: The default flexible payload configuration which extracts the first 16
> >>>     bytes of the payload for RSS will be deprecated starting from 18.02. If
> >>>     required the previous behavior can be configured using existing flow
> >>> --
> >>
> >> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > 
> > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > 
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Applied