From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41EC6C433B4 for ; Tue, 20 Apr 2021 21:34:14 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 7023C613F6 for ; Tue, 20 Apr 2021 21:34:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7023C613F6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EFED41735; Tue, 20 Apr 2021 23:34:12 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id DE8E141439 for ; Tue, 20 Apr 2021 23:34:10 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id A6BB5418F; Tue, 20 Apr 2021 17:34:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 20 Apr 2021 17:34:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= lP21/lEyq96tlGxVtfBc2uKEWkyXZZ3Qf489zyV5gbg=; b=bWUh2ZJF/sC0j/QY sxdiMJdzhZ6p5DLSGS73g7Ivp4uFeynua68rD74W7SwUttP6/t57ZRANrjZiM2Lm GpXYdVnaPo5eoi7gyaSrWxUQv7yT3l+cnKZn41hPkbWTNsNFf8WjZQmif0E7v1/B TVvMWt6a/vgsMYPI7/gN8KcBeF2FpXcTnCRI0psdxaeh85HCeMbAWRJtcc+JRDix j8h4IWpzxnSnDkrbOcyq+I3VEPJPktg6qVdDvrsXXg2jktfP8bP4pQ8ulBY4kZu8 2HWa3zdh0qf8oJV+CAc6L7uUkmDS/cLBBEJO1dSPVaBoJaU2QTKmkbtDfGQDJy40 CPlhDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=lP21/lEyq96tlGxVtfBc2uKEWkyXZZ3Qf489zyV5g bg=; b=vdZMwDmTTIJj9zBjfXlfaiLZ0yzrUac98cazadq/251S0qOCK/Yf9emFn opZVl5bBBPBZjQpUtIj67bfkrQq3w83DQ98uCnDENjnPbj4+uVP7oUDSpkKrjOZv Jqq//HSCylD9AsgMv/zL4khH78RVT44/JCnfPdRRGBJYm4aO/ghuQpWXdYAqG0ku wD3e6C5QNQSG4dB56qzZ5+Ixp/ISMeKS8FiEU04l4B8SAwvnR3/MspcOzfsIZeYO 859XgbP+XaJMouVGuah/fQ3djLzqXZ4majxVCnT5jax7Qw265vaSBVxQHRxIZzrC H2qBUpeSxISUYLrhFNyU6iIyw1mOA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtiedgudeihecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 35C5224005D; Tue, 20 Apr 2021 17:34:08 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, David Marchand , "Burakov, Anatoly" Date: Tue, 20 Apr 2021 23:34:06 +0200 Message-ID: <5077809.PuZuFd68Zz@thomas> In-Reply-To: <8fd733b5-fb6c-19ed-81ee-e755514f257f@intel.com> References: <20210409171631.18219-1-dmitry.kozliuk@gmail.com> <8fd733b5-fb6c-19ed-81ee-e755514f257f@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mem: fix cleanup after incomplete initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/04/2021 18:49, Burakov, Anatoly: > On 09-Apr-21 6:16 PM, Dmitry Kozlyuk wrote: > > In case of EAL initialization failure rte_eal_memory_detach() may be > > called before mapping memory configuration, which in this case points > > to the static structure. Attempt to unmap it yields error: > > > > EAL: Could not unmap shared memory config: Invalid argument > > > > Skip unmapping memory configuration if it's not yet shared. > > > > Fixes: dfbc61a2f9a6 ("mem: detach memsegs on cleanup") > > Cc: Anatoly Burakov > > > > Reported-by: David Marchand > > Signed-off-by: Dmitry Kozlyuk > > Acked-by: Anatoly Burakov Applied, thanks