From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] examples/l3fwd: force CRC stripping for
	i40evf
Date: Thu, 10 Nov 2016 15:32:17 +0100
Message-ID: <50996464.o08F9XFMCf@xps13>
References: <5952EEAD-ED55-4C0B-86EB-945B87637CD2@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "bjorn.topel@gmail.com" <bjorn.topel@gmail.com>, "Yao,
 Lei A" <lei.a.yao@intel.com>, "Topel, Bjorn" <bjorn.topel@intel.com>, "Zhang,
 Helin" <helin.zhang@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Xu, Qian Q" <qian.q.xu@intel.com>,
 "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Mori, Naoyuki" <naoyuki.mori@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 6CA8D9E7
 for <dev@dpdk.org>; Thu, 10 Nov 2016 15:32:19 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id u144so53034916wmu.1
 for <dev@dpdk.org>; Thu, 10 Nov 2016 06:32:19 -0800 (PST)
In-Reply-To: <5952EEAD-ED55-4C0B-86EB-945B87637CD2@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-11-10 13:50, Mori, Naoyuki:
> Hi,
> 
> >    Thomas wrote:
> >     > Just to make it sure, you mean returning an error in the driver when
> >     > a configuration cannot be applied, right?
> >    
> >    Yes, as in 1bbcc5d21129 ("i40evf: report error for unsupported CRC
> >    stripping config"), where -EINVAL is returned.
> >    
> >    Bj?rn
> 
> On my experience, OvS+DPDK has same issue.
> You cannot run OvS on i40evf due to this CRC config mismatch, while OvS on ixgbevf works fine.
> So, changing on i40evf PMD side would have more benefit, I believe.

No I think OVS should handle the configuration error.
We could also add a function to query this capability before configuring.