From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 10/12] mk: install examples
Date: Thu, 03 Dec 2015 14:32:53 +0100
Message-ID: <5099957.difSTsvb7d@xps13>
References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>
 <1449118929-19962-11-git-send-email-thomas.monjalon@6wind.com>
 <56604155.9080007@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Panu Matilainen <pmatilai@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id A6C642E81
 for <dev@dpdk.org>; Thu,  3 Dec 2015 14:34:02 +0100 (CET)
Received: by wmww144 with SMTP id w144so22311010wmw.0
 for <dev@dpdk.org>; Thu, 03 Dec 2015 05:34:02 -0800 (PST)
In-Reply-To: <56604155.9080007@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-03 15:19, Panu Matilainen:
> On 12/03/2015 07:02 AM, Thomas Monjalon wrote:
> > The examples are part of the installed documentation.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> >   mk/rte.sdkinstall.mk | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
> > index 902a933..13fa819 100644
> > --- a/mk/rte.sdkinstall.mk
> > +++ b/mk/rte.sdkinstall.mk
> > @@ -154,3 +154,4 @@ ifneq ($(wildcard $O/doc/*/*/*pdf),)
> >   	$(Q)$(call rte_mkdir,     $(DESTDIR)$(docdir)/guides)
> >   	$(Q)cp -a $O/doc/*/*/*pdf $(DESTDIR)$(docdir)/guides
> >   endif
> > +	$(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir)
> >
> 
> If examples are considered documentation (and I agree on that), then 
> shouldn't they be installed in $(docdir) instead?

I was hesitating. I think it's strange to install some code in
/usr/share/doc/.
It's not really important and may be changed easily at any time.