From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 12/14] net/avf: enable sse vector Rx Tx
	func
Date: Mon, 4 Dec 2017 12:01:16 -0800
Message-ID: <50cc7331-b737-4cc7-9a02-7f78a7c38206@intel.com>
References: <1508488012-82704-1-git-send-email-jingjing.wu@intel.com>
 <1511505206-97333-1-git-send-email-jingjing.wu@intel.com>
 <1511505206-97333-13-git-send-email-jingjing.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: wenzhuo.lu@intel.com
To: Jingjing Wu <jingjing.wu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id BC09A2B99
 for <dev@dpdk.org>; Mon,  4 Dec 2017 21:01:17 +0100 (CET)
In-Reply-To: <1511505206-97333-13-git-send-email-jingjing.wu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/23/2017 10:33 PM, Jingjing Wu wrote:
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

<...>

> @@ -233,6 +233,7 @@ CONFIG_RTE_LIBRTE_AVF_DEBUG_TX=n
>  CONFIG_RTE_LIBRTE_AVF_DEBUG_TX_FREE=n
>  CONFIG_RTE_LIBRTE_AVF_DEBUG_RX=n
>  CONFIG_RTE_LIBRTE_AVF_16BYTE_RX_DESC=n
> +CONFIG_RTE_LIBRTE_AVF_INC_VECTOR=y

Can you please move this just below CONFIG_RTE_LIBRTE_AVF_PMD, since this
enable/disable vector PMD more important than debug configs.

<...>

> +#ifdef RTE_LIBRTE_AVF_INC_VECTOR
> +static inline bool
> +check_rx_vec_allow(struct avf_rx_queue *rxq)
> +{
> +	if (rxq->rx_free_thresh >= AVF_VPMD_RX_MAX_BURST &&
> +	    rxq->nb_rx_desc % rxq->rx_free_thresh == 0) {
> +		PMD_INIT_LOG(DEBUG, "Vector Rx"
> +				    " can be enabled on this rxq.");
> +		return TRUE;
> +	}
> +
> +	PMD_INIT_LOG(DEBUG, "Vector Rx"
> +			    " cannot be enabled on this rxq.");

Can merge these two lines.

<...>

>  
> -/* choose rx function*/
> +/* choose tx function*/

Can you please fix this when added in patch 4/14?

<...>

> +					rte_mempool_put_bulk(free[0]->pool,
> +							     (void *)free,

Is void * cast required?

<...>