From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: fix dependencies to optional configs Date: Thu, 30 Mar 2017 15:37:48 +0200 Message-ID: <5105711.cJhHzCpTQQ@xps13> References: <20170330141120.2dbefae4@platinum> <20170330123228.28567-1-olivier.matz@6wind.com> <14477004-6f7c-04c4-e12c-15cf64909da4@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ferruh Yigit , dev@dpdk.org To: Olivier Matz Return-path: Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 8717911066 for ; Thu, 30 Mar 2017 15:37:50 +0200 (CEST) Received: by mail-lf0-f43.google.com with SMTP id h125so26631628lfe.0 for ; Thu, 30 Mar 2017 06:37:50 -0700 (PDT) In-Reply-To: <14477004-6f7c-04c4-e12c-15cf64909da4@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-30 13:37, Ferruh Yigit: > On 3/30/2017 1:32 PM, Olivier Matz wrote: > > In rte.lib.mk, the list of libraries passed to the link > > command (LDLIBS) is generated from the DEPDIRS-xxx variables. > > If a library is not compiled because it is disabled in > > configuration, it should not appear in DEPDIRS-xxx. > > > > - librte_port depends on librte_kni only if it is enabled. > > - librte_table depends on librte_acl only if it is enabled. > > > > Fixes: feb9f680cd2c ("mk: optimize directory dependencies") > > Reported-by: Ferruh Yigit > > Signed-off-by: Olivier Matz > > Tested-by: Ferruh Yigit Applied, thanks