From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] devtools/check-symbol-changes.sh: awk script
	issue
Date: Fri, 19 Oct 2018 12:48:57 +0200
Message-ID: <5107033.R7BcetJnk1@xps>
References: <1538666296-25742-1-git-send-email-liang.j.ma@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Liang Ma <liang.j.ma@intel.com>
To: nhorman@tuxdriver.com
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DF4951B47A
 for <dev@dpdk.org>; Fri, 19 Oct 2018 12:48:54 +0200 (CEST)
In-Reply-To: <1538666296-25742-1-git-send-email-liang.j.ma@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Neil,

Are you OK with this patch?


04/10/2018 17:18, Liang Ma:
> There is a issue inside check-symbol-changes.sh awk script.
> When the script try to parse the section name from  patch,
> The script put char "+" into the section name.
> 
> Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> ---
>  devtools/check-symbol-change.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index c0d2a6d..4a0f4d8 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -30,7 +30,7 @@ build_map_changes()
>  		# the rest of the line with the + and { symbols remvoed.
>  		# Triggering this rule sets in_sec to 1, which actives the
>  		# symbol rule below
> -		/^.*{/ {
> +		/^[^-+]*{/ {
>  			if (in_map == 1) {
>  				sec=$(NF-1); in_sec=1;
>  			}